Alt col name bug fix for option to handle larger dataset for location models #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- person_id is not compatible for tour and trip destination models, should use tour_id or trip_id instead - to make this variable for generic, the code will now use the first column in the alternative data file
…ransLinkForecasting/activitysim into location_estimation_patch
jpn--
approved these changes
Feb 13, 2024
|
This looks fine. We need a more robust estimation mode system with rigorous testing to catch these problems, but this is a reasonable patch for now. Will merge once we confirm none of the existing tests are broken (which seems quite unlikely but just in case...) Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix bug related to a hard-coded variable name in #687 when building the estimation data in chunks.
The previous pull request uses exclusively person_id, which means it will only work for mandatory destination EDBs. This change will mean that tour and trip destination EDBs will also work. This fix relies on the ID column inside the alternative data for EDB being the first column, which currently is the case.